keyword static should come before thread local qualifier#166
Open
nedm2 wants to merge 1 commit intoyse:developfrom
Open
keyword static should come before thread local qualifier#166nedm2 wants to merge 1 commit intoyse:developfrom
nedm2 wants to merge 1 commit intoyse:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static should come before __thread etc. This causes warnings with clang when using e.g. EASY_THREAD:
warning: '__thread' before 'static' [-Wpedantic]
It seems this was partially addressed with 53289ce but some instances were missed.